On 2006-03-22T19:34:35, [email protected] wrote:
> linux-ha CVS committal
>
> Author : panjiam
> Host :
> Project : linux-ha
> Module : cts
>
> Dir : linux-ha/cts
>
>
> Modified Files:
> Makefile.am
> Added Files:
> OCFDummy2.in LSBDummy.in
>
>
> Log Message:
> added 2 dummy RAs for CTS testing
> ===================================================================
> RCS file: /home/cvs/linux-ha/linux-ha/cts/Makefile.am,v
> retrieving revision 1.10
> retrieving revision 1.11
> diff -u -3 -r1.10 -r1.11
> --- Makefile.am 27 Feb 2006 09:19:42 -0000 1.10
> +++ Makefile.am 23 Mar 2006 02:34:35 -0000 1.11
> @@ -35,3 +35,10 @@
> CIB.py
>
> hard_DATA = README
> +
> +ocfdir = $(OCF_RA_DIR)/heartbeat/
> +ocf_SCRIPTS = OCFDummy2
> +
> +lsbdir = /etc/init.d/
> +lsb_SCRIPTS = LSBDummy
> +
We already have an ocf "Dummy" resource, why you're not using that?
And you're hardcoding the path to the init scripts; that's broken.
Besides, installing an LSB init script as part of the regular install is
not allowed; please split this off into a separate -cts subpackage.
Sincerely,
Lars Marowsky-Brée
--
High Availability & Clustering
SUSE Labs, Research and Development
SUSE LINUX Products GmbH - A Novell Business -- Charles Darwin
"Ignorance more frequently begets confidence than does knowledge"
_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/
