On 2009-09-16T14:41:35, Dejan Muhamedagic <[email protected]> wrote:

> The statusfile_prefix parameter should not affect the basic
> monitor operation. I think that if it does that will be source of
> confusion.

I don't think it will cause confusion, but it would make the "old"
behaviour unavailable; that isn't good, so depth=0 should remain as it
is today.

In particular, the initial probe shouldn't do this, I think; for that,
the depth=0 as of today is fully sufficient.

> Not sure, but I don't think so. I think it's up to the RA to
> interpret it at will. At any rate, multiple depths may be
> supported.

Yes, it's not defined anywhere.

> > It does. I just thought it would be helpful to see the node name in there.
> 
> You can then set the default to: .`uname`.${OCF_RESOURCE_INSTANCE}.

That isn't a good default. It'd end up cluttering the fs eventually, as
nothing exists to clean it up.

> I think it's good that it starts with '.' because it's of no
> importance to the normal users. Perhaps we could also reserve a
> directory named say .OCF_Filesystem_monitor/. I doubt that that
> name would collide with normal users.

I'd suggest that most users would add a directory name to their prefix,
yes.

Unless we want them to enter special characters and 'eval' the
string in the RA, I suggest we only allow them to set the prefix, and
append `uname -n`.{instance}.{clone_no} to it.

A good read-only test that doesn't cause any files to show up is to stat
the mountpoint; that may be a good level 10. Combining all ideas
together, I end up with ...

0       As today
10      stat()
20      read file
30      create-delete file
40      create-write-read-delete file

I'd suggest conv=fdatasync/fsync instead of flag=direct.

Which should really allow everyone to be happy (perhaps 30 isn't
needed).

They could be numbered 0,1,2,3,4 of course, but I'd like to leave some
space in-between for adding features.


Regards,
    Lars

-- 
Architect Storage/HA, OPS Engineering, Novell, Inc.
SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg)
"Experience is the name everyone gives to their mistakes." -- Oscar Wilde

_______________________________________________________
Linux-HA-Dev: [email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev
Home Page: http://linux-ha.org/

Reply via email to