On 2009-09-16T18:53:45, Florian Haas <[email protected]> wrote:
> > That isn't a good default. It'd end up cluttering the fs eventually, as > > nothing exists to clean it up. > Really? > http://hg.linux-ha.org/agents/file/f8bc24bc1db4/heartbeat/Filesystem#l671 On a clean stop, yes ;-) If all stops were clean, we wouldn't need fail-over software ;-) (I'd suggest to compute the string in some function somewhere, to make sure its always identical. Typos creep in way too quickly.) The monitor op probably should also check whether this file exists before trying to IO to it. > > I'd suggest conv=fdatasync/fsync instead of flag=direct. > The other Lars suggested that as well. :) But what about reads? Is there > any filesystem-agnostic way of saying "I want to read what's on disk, > rather than in cache" that's actually _better_ than opening the file > with O_DIRECT (realizing that it's a no-op for some filesystems)? For reading you're right, yes. Regards, Lars -- Architect Storage/HA, OPS Engineering, Novell, Inc. SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) "Experience is the name everyone gives to their mistakes." -- Oscar Wilde _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
