On 04/04/2012 02:55 PM, Lars Marowsky-Bree wrote: > that patch shares a *lot* of code with IPaddr(2), doesn't it? > > I wonder if that wouldn't benefit from refactoring, moving shared > functions to an include?
Thanks for your feedback, I will have a look at that - the gratuitous arp and also some paramter parsing are somewhat shared, although the exact requirements tend to differ in subtle ways when proxyarp and IPaddr2 are compared. I currently wonder how to test the Functionality of IPaddr2, as it is quite complex as soon as it comes to cluster IP. (In short: is there a somewhat self contained and exhaustive test for all possible operations and configurations of IPaddr2? The ocft does not seem to cut it for that, if I am not mistaken) Best Regards, Christian Franke _______________________________________________________ Linux-HA-Dev: [email protected] http://lists.linux-ha.org/mailman/listinfo/linux-ha-dev Home Page: http://linux-ha.org/
