>>> Florian Haas <[email protected]> schrieb am 25.11.2011 um 14:35 in
Nachricht <[email protected]>:

[...]
> ... and I just morphed that patch into a git branch. Ulrich, as much as
> we're all grateful for contributions to resource agents, _please_ don't
> mix functional modification with "cleanup" such as whitespace
> modifications. It makes the review awfully tedious.

I know, but inconsistend indentation should have been fixed before releasing. 
Anyway, did you try option "-b" or "-w"?

> 
> I've now _tried_ to fix up this patch into reasonably logical chunks,
> and pushed it to the "xinetd" branch in my github repo. This doesn't
> mean I'm endorsing or sponsoring the patch, just trying to make it
> easier for others to review.

I know it's not perfect, but it's closer on how it should be IMHO.

Regards,
Ulrich

> 
> The commit history (on top of the upstream master branch) is here:
> 
> https://github.com/fghaas/resource-agents/compare/master...xinetd 
> 
> Cheers,
> Florian
> 
> 

 
 

_______________________________________________
Linux-HA mailing list
[email protected]
http://lists.linux-ha.org/mailman/listinfo/linux-ha
See also: http://linux-ha.org/ReportingProblems

Reply via email to