On Tue, 16 Sep 2025 22:25:14 +0200, Dang Huynh via B4 Relay <devnull+dang.huynh.mainlining....@kernel.org> said: > From: Dang Huynh <dang.hu...@mainlining.org> > > The register doesn't like to be read, this causes the SD Card > Card Detect GPIO to misbehaves in the OS. >
Hi! Sorry but this message is unintelligible, please say precisely what is going on and why you need this and why it won't break existing users. Also: the title should be "gpio: rda: ...". Bartosz > Signed-off-by: Dang Huynh <dang.hu...@mainlining.org> > --- > drivers/gpio/gpio-rda.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpio/gpio-rda.c b/drivers/gpio/gpio-rda.c > index > b4db8553a2371ae407fdb7e681d0f82c4d9f74b7..56aaa9f33d29469dfb1bf86ed7b63c54b413c89c > 100644 > --- a/drivers/gpio/gpio-rda.c > +++ b/drivers/gpio/gpio-rda.c > @@ -245,7 +245,7 @@ static int rda_gpio_probe(struct platform_device *pdev) > .clr = rda_gpio->base + RDA_GPIO_CLR, > .dirout = rda_gpio->base + RDA_GPIO_OEN_SET_OUT, > .dirin = rda_gpio->base + RDA_GPIO_OEN_SET_IN, > - .flags = BGPIOF_READ_OUTPUT_REG_SET, > + .flags = BGPIOF_READ_OUTPUT_REG_SET | BGPIOF_UNREADABLE_REG_DIR, > }; > > ret = gpio_generic_chip_init(&rda_gpio->chip, &config); > > -- > 2.51.0 > > >
