> I agree, but I still don't like squashing the two patches together. I forgot > to > mention it last time, but please, look at the patches one more time. Jurgens' > does the DT change and mine fixes the PIO on MX23, I'd like to keep these > changes separate.
Ok, as said, I am not pushing hard on this. > > Then, add the comment to the check so ppl will notice there? > > If I could add a big red flashing sign into the code stating "If you go over > 4 > bytes here, a kitten will die", then by all means, I would add it. > Unfortunatelly, there is no such thing possible. I'd say if somebody changes the code with that comment on top of it, it is really deserved... > Maybe WARN_ONCE and return with error might just work? ... but if you insist, I can accept this. Thanks, Wolfram
signature.asc
Description: Digital signature
