Mon, 28 Apr 2014 20:26:00 -0700 от Dmitry Torokhov <[email protected]>: > Hi Alexander, > > On Sat, Apr 26, 2014 at 09:53:13AM +0400, Alexander Shiyan wrote: > > Replace existing resource handling in the driver with managed > > device resource, this ensures more consistent error values and > > simplifies error paths. > > kzalloc -> devm_kzalloc > > gpio_request_one -> devm_gpio_request_one > > > > If we are doing the conversion can we go all the Alexanderway (needs the > other 2 patches I just posted and CCed you)? > > Thanks. > > -- > Dmitry > > Input: gpio_keys_polled - convert to devm-* API > > From: Alexander Shiyan <[email protected]> > > Replace existing resource handling in the driver with managed device > resources, this ensures more consistent error values and simplifies error > handling paths: > > kzalloc -> devm_kzalloc > gpio_request_one -> devm_gpio_request_one > input_allocate_polled_device -> devm_input_allocate_polled_device > > Signed-off-by: Alexander Shiyan <[email protected]> > Signed-off-by: Dmitry Torokhov <[email protected]> > --- ... > @@ -162,8 +160,7 @@ static struct gpio_keys_platform_data > *gpio_keys_polled_get_devtree_pdata(struct > if (of_property_read_u32(pp, "linux,code", &button->code)) { > dev_err(dev, "Button without keycode: 0x%x\n", > button->gpio); > - error = -EINVAL; > - goto err_free_pdata; > + return ERR_PTR(-EINVAL); > }
We can even use return value from of_property_read_u32() on error. All other looks OK. ---
