On Mon, May 12, 2014 at 11:15:02AM +0400, Alexander Shiyan wrote: > Mon, 5 May 2014 21:18:18 -0700 от Dmitry Torokhov <[email protected]>: > > On Tue, Apr 29, 2014 at 08:40:59PM +0400, Alexander Shiyan wrote: > > > Tue, 29 Apr 2014 09:36:49 -0700 от Dmitry Torokhov > > > <[email protected]>: > > > > On Tue, Apr 29, 2014 at 08:24:19PM +0400, Alexander Shiyan wrote: > > > ... > > > > > > > > > > On Sat, Apr 26, 2014 at 09:53:13AM +0400, Alexander Shiyan > > > > > > > > > > wrote: > > > > > > > > > > > Replace existing resource handling in the driver with > > > > > > > > > > > managed > > > > > > > > > > > device resource, this ensures more consistent error > > > > > > > > > > > values and > > > > > > > > > > > simplifies error paths. > > > > > > > > > > > kzalloc -> devm_kzalloc > > > > > > > > > > > gpio_request_one -> devm_gpio_request_one > > > > > > > ... > > > > > > > > > > @@ -162,8 +160,7 @@ static struct gpio_keys_platform_data > > > > > > > > > > *gpio_keys_polled_get_devtree_pdata(struct > > > > > > > > > > if (of_property_read_u32(pp, "linux,code", > > > > > > > > > > &button->code)) { > > > > > > > > > > dev_err(dev, "Button without keycode: > > > > > > > > > > 0x%x\n", > > > > > > > > > > button->gpio); > > > > > > > > > > - error = -EINVAL; > > > > > > > > > > - goto err_free_pdata; > > > > > > > > > > + return ERR_PTR(-EINVAL); > > > > > > > > > > } > > > > > > > > > > > > > > > > > > We can even use return value from of_property_read_u32() on > > > > > > > > > error. > > > > > > > > > > > > > > > > > > All other looks OK. > > > > > > > > > > > > > > > > Do you have hardware that uses gpio_keys_polled? > > > > > > > > > > > > > > Yes. > > > > > > > > > > > > So did you have a chance to actually try my version(s)? I would feel > > > > > > much better if you had ;) > > > > > > > > > > Unfortunately, due to the large following weekends, I cannot do it > > > > > earlier > > > > > than 2 weeks. > > > > > > > > That is fine, there is no rush. > > > > > > OK. In this case it would be nice to have a separate branch with > > > poll-series > > > and this patch. Can you make it? > > > > I just pushed new input-polldev branch containing input polldev changes > > and your patches to gpio-keys and gpio-keys-polled. It is based on 3.14. > > This works for me as expected, so: > > Tested-by: Alexander Shiyan <[email protected]>
Thank you Alexander, I queued them all for the next merge window. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
