On Fri, Dec 19, 2025 at 09:43:27AM +0000, Jonathan McDowell wrote: > On Tue, Dec 16, 2025 at 11:21:37AM +0200, Jarkko Sakkinen wrote: > > tpm1_get_random() and tpm2_get_random() contain duplicate orchestration > > code. Consolidate orchestration to tpm_get_random(). > > Does keeping the respective tpm1/tpm2 bits in their -cmd.c files not make > more sense, still allowing for the consolidation of orchestration in > tpm_get_random?
Yeah, especially after not paying attention to this for couple of weeks this really feels like unnecessary. It would also reduce the overall delta caused by these patches. I will take here step back and retain the helpers in tpm1/tpm2-cmd.c files. BR, Jarkko
