On Thu, 24 Aug 2000 10:53:25 -0700, you wrote:
> On Thu, Aug 24, 2000 at 09:33:31AM -0700, Jean Tourrilhes wrote:

> > > What am I missing here?
> > 
> >     The dev->name of any irtty device is truncated to
> > "irda". 

Why? What's truncating it?

>> Check by yourself with an ifconfig. The trouble is that you
> > can't have 2 irtty active at the same time.

I have no problem with this! Are you sure you have a clean
patch? My patch is removing _all_ the memsets from the
patch, so there should be no problems at all! 

[root@dag-laptop dagb]# ifconfig 
irda0     Link encap:IrLAP  HWaddr 97:ba:6e:0a  
          UP RUNNING NOARP  MTU:2048  Metric:1
          RX packets:16790 errors:18 dropped:0 overruns:0 frame:18
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:8 

irda1     Link encap:IrLAP  HWaddr 97:ba:6e:0aea:79:10:50  
          UP RUNNING NOARP  MTU:2048  Metric:1
          RX packets:0 errors:0 dropped:0 overruns:0 frame:0
          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
          collisions:0 txqueuelen:8 

> right. Just replace the contentious line with :
> ------------------------------------------
>       /* dev_alloc doesn't clear the struct */
>       memset(((__u8*)dev)+sizeof(dev->name),0,sizeof(struct 
>net_device)-sizeof(dev->name));
> ------------------------------------------
>       This is much more readable, and this way, whatever the
> definition of dev->name become, we will do the right thing. And it's
> compatible for both 2.2 and 2.4. Magic !

I still don't see why we should clear the struct in 2.4 when it's
already done by dev_alloc(). What if they insert something before
the name?
 
>       Jean

----
Dag Brattli,                       Mail:  [EMAIL PROTECTED]
Senior Systems Engineer            Web:   http://www.fast.no/
Fast Search & Transfer ASA         Phone: +47 776 96 688
P.O. Box 1126                      Fax:   +47 776 96 689
NO-9261 Troms�, NORWAY             Cell:  +47 924 05 388

_______________________________________________
Linux-IrDA mailing list  -  [EMAIL PROTECTED]
http://www4.pasta.cs.UiT.No/mailman/listinfo/linux-irda

Reply via email to