On Sat, Aug 26, 2000 at 02:20:56AM -0700, Dag Brattli wrote:
> > >
> > > The dev->name of any irtty device is truncated to
> > > "irda".
>
> Why? What's truncating it?
The memset operation.
> I have no problem with this! Are you sure you have a clean
> patch? My patch is removing _all_ the memsets from the
> patch, so there should be no problems at all!
>
> [root@dag-laptop dagb]# ifconfig
> irda0 Link encap:IrLAP HWaddr 97:ba:6e:0a
> UP RUNNING NOARP MTU:2048 Metric:1
> RX packets:16790 errors:18 dropped:0 overruns:0 frame:18
> TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:8
>
> irda1 Link encap:IrLAP HWaddr 97:ba:6e:0aea:79:10:50
> UP RUNNING NOARP MTU:2048 Metric:1
> RX packets:0 errors:0 dropped:0 overruns:0 frame:0
> TX packets:0 errors:0 dropped:0 overruns:0 carrier:0
> collisions:0 txqueuelen:8
Yes, if you remove all the memset, things should be totally fine.
> I still don't see why we should clear the struct in 2.4 when it's
> already done by dev_alloc(). What if they insert something before
> the name?
I'm sorry, I didn't express myself clearly, I misunderstood
you, and I apologise with the mess.
What I was saying is that the memset was problematic, and if
we were to do a memset, we should have done it this way. I was not
advocating doing a memset, I was just saying that we should not do the
memset the old way.
Whichever solution you choose, doing the memset the new way
*or* removing the memset is fine with me. In fact, if removing the
memset do work, that's even better ;-)
Sorry again...
Jean
_______________________________________________
Linux-IrDA mailing list - [EMAIL PROTECTED]
http://www4.pasta.cs.UiT.No/mailman/listinfo/linux-irda
