2006-07-18: Keith Bennett dixit: > Okay. Here it is [lkarmafs-0.1.7-escape.patch]. > I've made some changes since I last tested so there's a fair > chance that it doesn't work anymore! Seems okay on the brief > testing I did just now.
2006-07-20: EV dixit: > Sorry, I'm too busy for a few days -- until mid next week. > I'll take care of it then... Thanks for the patch! I'm testing it now and it ooks fine: nothing seems to be broken ;) However, I don't really like the *change* of tr-edditing for escaping. I think path escape-edditing can lead to ugly paths in some cases. If the user (me ;) is confident enough about the reversibility of tr-edditing, he/she may (strongly) preffer tr than escape. For instance, with 'lkarmafs -E "/ " "#_" mnt/' you get things like: mnt/tune/Jazz/Carmen\_McRae/Blue\_Moon/My\_Foolish\_Heart.mp3 On the other hand, I don't quite understand the motivation for both escaping *and* substituting. If you doubt of some critical char like ':' you may want to escape *it*; i.e., '\:', but not something like '\@'. So I think escape-edditing should be optional or additional to tr-edditing. For the moment I'm keeping lkarmafs-0.1.7 as the current tree. If you want to send in another patch, please do it against 0.1.7. Otherwise, I'll take some other parts of your patch (like codec = strrchr(title, '.')) and I'll try myself to add optional escaping. > kfs_readdir() could do with a bit more cleaning up. Agree -- it is in fact in the TODO ;) > I might be missing something, but the testing for reps part > seems a bit off. aux has the codec appended incorrectly, I > think. Not sure that the aux string is necessary at all for > this part. I'll take another look tomorrow. As far as I remember, aux (and the wired codec appending) became necessary to change the RK codec value "vorbis" for "ogg". Nevertheless, I'll take another look tomorrow to see if I find some bug (even though the testing doesn't reveal anything wrong). Best, EV. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys -- and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ linux-karma-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
