On Sun, Jul 30, 2006, EV wrote:
> After more testing of your latest patchs
> (lkarmafs-0.1.7-escape3.patch and lkarmafs-0.1.7-escape3.patch +
> lkarmafs-0.1.7-rep.patch), here are my conclussions:
>
> - I think the escape3.patch functionality of the -E option
> (escape-editing of the originals) is fine. So, unless other
> users complain, I think we can keep *only* your escape path
> editing (i.e., forget about my wish of retaining both tr- and
> escape-editing).
Good. That simplifies things.
> - The default editing (i.e., no -E option) of the escape3.patch
> version is not good: tunes having a '/' in their title are not
> shown and the same happens for tunes having one or more ".".
> Examples: title="A / B" or title="X.Y".
I am unable to reduce this behaviour. I have only tested with escape3+rep
but I've generated a fair number of tracks containing both '/' and '.'
and the all work as advertised. Can you post any specific examples?
> - The default editing (i.e., no -E option) of the
> escape3+rep.patch version is fine, except that I think most
> people would prefer NOT to substitute " " with "_" by default.
> I'd also use another symbol for the "/"; for instance '+', '%',
> '|' or, if possible, '\' -- instead of '#'.
Agreed.
> - The editing option of the rep.patch version is broken: for
> instance, using `-E "/." "+Ç"' yields `** Libkarma error:
> gethostbyname() failed'
Doh! Stupid bug.
The attached patch fixes this and changes the default editing.
Keith.
diff -ur lkarmafs-0.1.7.orig/lkarmafs.c lkarmafs-0.1.7/lkarmafs.c
--- lkarmafs-0.1.7.orig/lkarmafs.c 2006-07-30 13:30:27.000000000 +0100
+++ lkarmafs-0.1.7/lkarmafs.c 2006-07-30 13:31:47.000000000 +0100
@@ -54,9 +54,9 @@
#define UNK_NAME "-UnKnown-"
-#define TR_FRM " /"
-#define TR_TO "_#"
-#define TR_SLASH '#'
+#define TR_FRM "/"
+#define TR_TO "|"
+#define TR_SLASH '|'
#define CHECK(x) (x)?"failed":"ok"
@@ -1198,8 +1198,8 @@
editPathStr1 = malloc(len+2);
editPathStr2 = malloc(len+2);
- memcpy(editPathStr1, argv[i], len);
- memcpy(editPathStr2, argv[i+1], len);
+ memcpy(editPathStr1, argv[i++], len);
+ memcpy(editPathStr2, argv[i], len);
editPathStr1[len] = '\0';
editPathStr2[len] = '\0';
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
linux-karma-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/linux-karma-devel
