Borislav, we're talking about 1566 bytes of text here: > text data bss dec hex filename > 13874312 2633704 3014656 19522672 129e470 64bit-pkey/vmlinux > 13872746 2633648 3014656 19521050 129de1a 64bit-nopkey/vmlinux
For gains that small, we should barely even allow this thing to be configurable, much less default it to off. On 02/19/2016 09:23 AM, Borislav Petkov wrote: > On Fri, Feb 19, 2016 at 09:11:03AM -0800, Dave Hansen wrote: >> I'd really prefer this be left on by default. This is a feature that I >> expect to be widely enabled in distribution kernels. > > Distribution kernels can enable it without defaulting to y here. Yes, agreed. Distros _can_ override things. But, In general, *especially* with user-visible effects, I'd really like defconfig (or other build defaults) to be reasonably close to what distributions do. > Also, this code doesn't need to be built on the majority of x86 boxes > out there because they don't have the hw support. My view has always been that the folks that really care about binary size are the ones that will be the ones digging through their .configs turning things off. BTW, what percentage of x86 boxes must have a feature before we can enable it by default?
