Hi. 2016-07-06 0:25 GMT+09:00 Linus Walleij <[email protected]>: > On Tue, Jul 5, 2016 at 2:11 PM, Thierry Reding <[email protected]> > wrote: > >> From: Thierry Reding <[email protected]> >> >> When registering a GPIO chip, drivers can override the device tree node >> associated with the chip by setting the chip's ->of_node field. If set, >> this field is supposed to take precedence over the ->parent->of_node >> field, but the code doesn't actually do that. >> >> Commit 762c2e46c059 ("gpio: of: remove of_gpiochip_and_xlate() and >> struct gg_data") exposes this because it now no longer matches on the >> GPIO chip's ->of_node field, but the GPIO device's ->of_node field that >> is set using the procedure described above. >> >> Signed-off-by: Thierry Reding <[email protected]> > > Thanks for catching this, patch applied with Alexandre's ACK. > > Masahiro: does this look all right to you?
Yes. Now, the code matches to the comment. Nice! Reviewed-by: Masahiro Yamada <[email protected]> Question: When we reference the node of gpiochip, we should use chip->gpiodev->dev->of_node instead of chip->of_node because we can make chip->of_node optional as long as chip->parent is set in the probe method. Correct? -- Best Regards Masahiro Yamada
