On 12/1/2016 12:09 AM, Alex Williamson wrote: > On Wed, 30 Nov 2016 21:27:07 +0300 > Dan Carpenter <[email protected]> wrote: > >> On Wed, Nov 30, 2016 at 09:36:46AM -0700, Alex Williamson wrote: >>> On Wed, 30 Nov 2016 08:06:12 +0100 >>> Christophe JAILLET <[email protected]> wrote: >>> >>>> 'vfio_group_get_from_dev()' seems to return only NULL on error, not an >>>> error >>>> pointer. >>>> >>>> Fixes: 2169037dc322 ("vfio iommu: Added pin and unpin callback functions >>>> to vfio_iommu_driver_ops") >>>> Fixes: c086de818dd8 ("vfio iommu: Add blocking notifier to notify >>>> DMA_UNMAP") >>>> >>>> Signed-off-by: Christophe JAILLET <[email protected]> >>>> --- >>> >>> Dan Carpenter proposed a nearly identical patch: >>> >>> http://www.spinics.net/lists/kvm/msg141468.html >>> >>> The difference is you return -ENODEV while Dan returns -EINVAL. I tend >>> to prefer -ENODEV to distinguish this error case versus validation of >>> the other parameters. This patch also identifies both commits >>> introducing these, so I'm inclined to take this one rather than Dan's >>> version.
Agree with you Alex. This version looks better. Thanks, Kirti >>> Dan & Kirti, I welcome any credits you'd like to apply to >>> this patch for identifying and reviewing the same issue. Thanks, >>> >> >> Could I get a Reported-by? > > Sure thing, thanks, > > Alex >
