On 02-03-17, 15:45, Patrick Bellasi wrote: > diff --git a/kernel/sched/cpufreq_schedutil.c > b/kernel/sched/cpufreq_schedutil.c > @@ -293,15 +305,29 @@ static void sugov_update_shared(struct update_util_data > *hook, u64 time, > if (curr == sg_policy->thread) > goto done; > > + /* > + * While RT/DL tasks are running we do not want FAIR tasks to > + * overwrite this CPU's flags, still we can update utilization and > + * frequency (if required/possible) to be fair with these tasks. > + */ > + rt_mode = task_has_dl_policy(curr) || > + task_has_rt_policy(curr) || > + (flags & SCHED_CPUFREQ_RT_DL); > + if (rt_mode) > + sg_cpu->flags |= flags; > + else > + sg_cpu->flags = flags;
This looks so hacked up :) Wouldn't it be better to let the scheduler tell us what all kind of tasks it has in the rq of a CPU and pass a mask of flags? I think it wouldn't be difficult (or time consuming) for the scheduler to know that, but I am not 100% sure. IOW, the flags field in cpufreq_update_util() will represent all tasks in the rq, instead of just the task that is getting enqueued/dequeued.. And obviously we need to get some utilization numbers for the RT and DL tasks going forward, switching to max isn't going to work for ever :) -- viresh
