On Thu, Jul 20, 2017 at 02:31:09PM +0530, Arvind Yadav wrote:
> > "Constify attribute_group structs because they don't change at runtime."
> I can add this as subject. But we should avoid lengthy subject.
Are you actually reading what I'm writing to you? I said this should be
the commit message, not the subject.
What I'm saying is, shorten your commit message - no need for the
irrelevant before/after sizes. I'm not the first reviewer to ask WTF do
those things even mean.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
