Hi,
On Thursday 20 July 2017 04:01 PM, Borislav Petkov wrote:
On Thu, Jul 20, 2017 at 02:31:09PM +0530, Arvind Yadav wrote:
"Constify attribute_group structs because they don't change at runtime."
I can add this as subject. But we should avoid lengthy subject.
Are you actually reading what I'm writing to you? I said this should be
the commit message, not the subject.
What I'm saying is, shorten your commit message - no need for the
irrelevant before/after sizes. I'm not the first reviewer to ask WTF do
those things even mean.
Thanks :) for your suggestion. I will remove before/after size comparison.
and send you back for review.
~arvind
