Hi Antoine, 2017-08-28 8:55 GMT+02:00 Antoine Tenart <antoine.ten...@free-electrons.com>: > Hi Russell, > > On Fri, Aug 25, 2017 at 11:43:13PM +0100, Russell King - ARM Linux wrote: >> On Fri, Aug 25, 2017 at 04:48:12PM +0200, Antoine Tenart wrote: >> > The link mode (speed, duplex) was forced based on what the phylib >> > returns. This should not be the case, and only forced by ethtool >> > functions manually. This patch removes the link mode enforcement from >> > the phylib link_event callback. >> >> So how does RGMII work (which has no in-band signalling between the PHY >> and MAC)? >> >> phylib expects the network driver to configure it according to the PHY >> state at link_event time - I think you need to explain more why you >> think that this is not necessary. > > Good catch, this won't work properly with RGMII. This could be done > out-of-band according to the spec, but that would use PHY polling and we > do not want that (the same concern was raised by Andrew on another > patch). > > I'll keep this mode enforcement for RGMII then. >
Can you be 100% sure that when using SGMII with PHY's (like Marvell Alaska 88E1xxx series), is in-band link information always available? I'd be very cautious with such assumption and use in-band management only when set in the DT, like mvneta. I think phylib can properly can do its work when MDIO connection is provided on the board. Did you check the change also on A375? Best regards, Marcin