> -----Original Message-----
> From: Shawn Guo [mailto:shawn...@kernel.org]
> Sent: Friday, February 02, 2018 1:18 AM
> To: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
> Cc: Sascha Hauer <ker...@pengutronix.de>; Frank Li <frank...@nxp.com>;
> Fabio Estevam <fabio.este...@nxp.com>; Ian Ray <ian....@ge.com>; Rob
> Herring <robh...@kernel.org>; Mark Rutland <mark.rutl...@arm.com>;
> devicet...@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] ARM: dts: imx6q-bx50v3: Enable secure-reg-access
>
> + Frank
>
> On Mon, Jan 15, 2018 at 05:07:22PM +0100, Sebastian Reichel wrote:
> > From: Peter Senna Tschudin <peter.se...@collabora.com>
> >
> > Add secure-reg-access on device tree include file for Bx50 devices to
> > enable PMU and hardware counters for perf.
> >
> > Signed-off-by: Peter Senna Tschudin <peter.se...@collabora.com>
> > Signed-off-by: Sebastian Reichel <sebastian.reic...@collabora.co.uk>
> > ---
> > arch/arm/boot/dts/imx6q-bx50v3.dtsi | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/imx6q-bx50v3.dtsi
> > b/arch/arm/boot/dts/imx6q-bx50v3.dtsi
> > index 86cfd4481e72..ccaaee83e2fa 100644
> > --- a/arch/arm/boot/dts/imx6q-bx50v3.dtsi
> > +++ b/arch/arm/boot/dts/imx6q-bx50v3.dtsi
> > @@ -43,6 +43,13 @@
> > #include "imx6q-ba16.dtsi"
> >
> > / {
> > + soc {
> > + pmu {
> > + compatible = "arm,cortex-a9-pmu";
> > + secure-reg-access;
>
> I'm not sure this could be a board level configuration. Shouldn't this
> property
> just be added into pmu node in imx6qdl.dtsi?
I agree. It should be in imx6qdl.dtsi
Frank Li
>
> Shawn
>
> > + };
> > + };
> > +
> > clocks {
> > mclk: clock@0 {
> > compatible = "fixed-clock";
> > --
> > 2.15.1
> >
