Hi Naga, On Fri, 8 Jun 2018 05:20:33 +0000, Naga Sureshkumar Relli <[email protected]> wrote:
> Hi Miquel, > > Thanks for the review. > > > -----Original Message----- > > From: Miquel Raynal [mailto:[email protected]] > > Sent: Thursday, June 7, 2018 9:12 PM > > To: Naga Sureshkumar Relli <[email protected]> > > Cc: [email protected]; [email protected]; [email protected]; > > [email protected]; [email protected]; [email protected]; > > [email protected]; [email protected]; [email protected]; [email protected]; > > [email protected]; [email protected]; > > [email protected]; > > [email protected] > > Subject: Re: [LINUX PATCH v9 1/4] Devicetree: Add pl353 smc controller > > devicetree > > binding information > > > > Hi Naga, > > > > On Wed, 6 Jun 2018 13:19:39 +0530, Naga Sureshkumar Relli > > <[email protected]> wrote: > > > > > Add pl353 static memory controller devicetree binding information. > > > > > > Signed-off-by: Naga Sureshkumar Relli > > > <[email protected]> > > > --- > > > Changes in v9: > > > - Addressed commens given by Randy Dunlap and Miquel Raynal > > > > Can you please be more specific in your next changelog? I don't remember > > what I suggested a > > few months ago :) > Ok, I will update. > > > > > > Changes in v8: > > > - None > > > Changes in v7: > > > - Corrected clocks description > > > - prefixed '#' for address and size cells Changes in v6: > > > - None > > > Changes in v5: > > > - Removed timing properties > > > Changes in v4: > > > - none > > > Changes in v3: > > > - none > > > Changes in v2: > > > - modified timing binding info as per onfi timing parameters > > > - add suffix nano second as timing unit > > > - modified the clock names as per the IP spec > > > --- > > > .../bindings/memory-controllers/pl353-smc.txt | 53 > > ++++++++++++++++++++++ > > > 1 file changed, 53 insertions(+) > > > create mode 100644 > > > Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt > > > > > > diff --git > > > a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt > > > b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt > > > new file mode 100644 > > > index 0000000..551e66b > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.t > > > +++ xt > > > @@ -0,0 +1,53 @@ > > > +Device tree bindings for ARM PL353 static memory controller > > > + > > > +PL353 static memory controller supports two kinds of memory > > > +interfaces.i.e NAND and SRAM/NOR interfaces. > > > +The actual devices are instantiated from the child nodes of pl353 smc > > > node. > > > + > > > +Required properties: > > > +- compatible : Should be "arm,pl353-smc-r2p1" > > > > I thing Rob prefers: > > > > - compatible: Must be one of: > > * arm, pl353-smc-r2p1 > Are you suggesting any other compatibles? > Or just a change from "should be to Must be one of"? > > Just the rewording + making it a list in case we need to add new compatibles in the future. Thanks, Miquèl
