Hi Greg,
thanks for the review.
On 26/11/2018 16:06, Greg Kroah-Hartman wrote:
> On Mon, Nov 26, 2018 at 01:20:43PM +0100, Daniel Lezcano wrote:
>> --- a/drivers/base/arch_topology.c
>> +++ b/drivers/base/arch_topology.c
>> @@ -243,9 +243,20 @@ static int __init register_cpufreq_notifier(void)
>> * until we have the necessary code to parse the cpu capacity, so
>> * skip registering cpufreq notifier.
>> */
>> - if (!acpi_disabled || !raw_capacity)
>> + if (!acpi_disabled)
>> return -EINVAL;
>>
>> + if (!raw_capacity) {
>> +
>> + pr_info("cpu_capacity: No capacity defined in DT, set default "
>> + "values to %ld\n", SCHED_CAPACITY_SCALE);
>
> Why the extra blank line?
>
> And what is userspace going to do with this noise? Is this an error?
> Just normal operation? A device should never be saying anything to the
> log for normal boot functionality. When is this called?
It is not an error but a fallback path. It is called at init time when
the cpufreq notifier is called and when either the DT read failed or
nothing is specified. I agree this is noise, I will remove the trace.
> And no need for the "cpu_capacity:" right? Shouldn't the pr_info() line
> handle the prefix for you?
Ah, right I did not pay attention to the prefix and blindly copied the
line from somewhere else. I think it is better to drop this trace in any
case.
I will provide a patch setting the pr_fmt in a separate series.
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
