On 23/08/2019 14:13, Frank Wunderlich wrote:
> Hi,
>
> this commit breaks mt6323 pmic on BananaPi-R2
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a4872e80ce7d2a1844328176dbf279d0a2b89bdb
>
> resulting in this message in dmesg:
>
> mt6397 1000d000.pwrap:mt6323: unsupported chip: 0x0
> and multiple
> mtk-cpufreq mtk-cpufreq: failed to initialize dvfs info for cpu0
>
> see discussion here:
> http://lists.infradead.org/pipermail/linux-mediatek/2019-August/022505.html
>
> after reverting this one the errors are gone, please provide a fix
are you sure that you provide the correct chip_id here? I saw 0x2023 (if I
remember correctly), while this switch checks for 0x23, 0x91 and 0x97, so I'm
not sure if the problem really lies here. I didn't dig into the code to find out
how the chip_id is created.
Regards,
Matthias
>
> regards Frank
>
>
>> Gesendet: Freitag, 23. August 2019 um 05:45 Uhr
>> Von: "Hsin-Hsiung Wang" <hsin-hsiung.w...@mediatek.com>
>> Betreff: [PATCH v5 02/10] mfd: mt6397: extract irq related code from core
>> driver
>>
>> In order to support different types of irq design, we decide to add
>> separate irq drivers for different design and keep mt6397 mfd core
>> simple and reusable to all generations of PMICs so far.
>>
>> Acked-for-mfd-by: Lee Jones <lee.jo...@linaro.org>
>> Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.w...@mediatek.com>
>> ---
>> drivers/mfd/Makefile | 3 +-
>> drivers/mfd/mt6397-core.c | 146 --------------------------------
>> drivers/mfd/mt6397-irq.c | 181
>> ++++++++++++++++++++++++++++++++++++++++
>> include/linux/mfd/mt6397/core.h | 9 ++
>> 4 files changed, 192 insertions(+), 147 deletions(-)
>> create mode 100644 drivers/mfd/mt6397-irq.c
>
