On Mon, May 11, 2020 at 04:36:21PM +0800, WeiXiong Liao wrote:
> On 2020/5/11 AM 4:24, Kees Cook wrote:
> > [...]
> > + * @time: oops/panic trigger time
>
> The above comment should be corrected since it is not only oops/panic
> any more.
Ah yes, thanks! I'll clean these all up.
> > [...]
> > + if (hdr->reason == KMSG_DUMP_OOPS)
> > + hdr->counter = ++cxt->oops_counter;
> > + else
> > + hdr->counter = ++cxt->panic_counter;
>
> Here should be:
>
> if (hdr->reason == KMSG_DUMP_OOPS)
> hdr->counter = ++cxt->oops_counter;
> else if (hdr->reason == KMSG_DUMP_PANIC)
> hdr->counter = ++cxt->panic_counter;
> else
> hdr->counter = 0;
Good catch; thanks! I'll move the lost later hunk to here.
> > [...]
> > +MODULE_DESCRIPTION("Storage Manager for pstore/blk");
I'm going to leave this as-is for now since it's accurate for the
moment. :)
--
Kees Cook
