Hi John,
Thank you for the suggestion, please find my comment below:
> -----Original Message-----
> From: John Hubbard <jhubb...@nvidia.com>
> Sent: Wednesday 27 May 2020 02:26
> To: LKML <linux-kernel@vger.kernel.org>
> Cc: Souptick Joarder <jrdr.li...@gmail.com>; John Hubbard
> <jhubb...@nvidia.com>; Derek Kiernan <dkier...@xilinx.com>; Dragan
> Cvetic <drag...@xilinx.com>; Arnd Bergmann <a...@arndb.de>; Greg
> Kroah-Hartman <gre...@linuxfoundation.org>; Michal Simek
> <mich...@xilinx.com>; linux-arm-ker...@lists.infradead.org
> Subject: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() -->
> pin_user_pages()
>
> Hi,
>
> There are also a couple of tiny cleanup patches, just to fix up a few
> minor issues that I spotted while converting from get_user_pages_fast()
> to pin_user_pages_fast().
>
> Note that I have only compile-tested these patches, although that does
> also include cross-compiling for a few other arches. Any run-time
> testing would be greatly appreciated!
>
> Cc: Derek Kiernan <derek.kier...@xilinx.com>
> Cc: Dragan Cvetic <dragan.cve...@xilinx.com>
> Cc: Arnd Bergmann <a...@arndb.de>
> Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org>
> Cc: Michal Simek <michal.si...@xilinx.com>
> Cc: linux-arm-ker...@lists.infradead.org
>
> John Hubbard (3):
> misc: xilinx-sdfec: improve get_user_pages_fast() error handling
> misc: xilinx-sdfec: cleanup return value in xsdfec_table_write()
> misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()
Reviewed-by:
Technically there is no problem in this patch, but as you said this
should be tested.
Currently due to Covid-19 I'm not able to access the HW and I cannot
validate this suggestion.
>
> drivers/misc/xilinx_sdfec.c | 30 +++++++++++++++++-------------
> 1 file changed, 17 insertions(+), 13 deletions(-)
>
>
> base-commit: 9cb1fd0efd195590b828b9b865421ad345a4a145
> --
> 2.26.2
