On 2020-05-29 01:29, Dragan Cvetic wrote:
Hi John,
Thank you for the suggestion, please find my comment below:
-----Original Message-----
From: John Hubbard <[email protected]>
Sent: Wednesday 27 May 2020 02:26
To: LKML <[email protected]>
Cc: Souptick Joarder <[email protected]>; John Hubbard <[email protected]>;
Derek Kiernan <[email protected]>; Dragan
Cvetic <[email protected]>; Arnd Bergmann <[email protected]>; Greg Kroah-Hartman
<[email protected]>; Michal Simek
<[email protected]>; [email protected]
Subject: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() -->
pin_user_pages()
Hi,
There are also a couple of tiny cleanup patches, just to fix up a few
minor issues that I spotted while converting from get_user_pages_fast()
to pin_user_pages_fast().
Note that I have only compile-tested these patches, although that does
also include cross-compiling for a few other arches. Any run-time
testing would be greatly appreciated!
Cc: Derek Kiernan <[email protected]>
Cc: Dragan Cvetic <[email protected]>
Cc: Arnd Bergmann <[email protected]>
Cc: Greg Kroah-Hartman <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: [email protected]
John Hubbard (3):
misc: xilinx-sdfec: improve get_user_pages_fast() error handling
misc: xilinx-sdfec: cleanup return value in xsdfec_table_write()
misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()
Reviewed-by:
Technically there is no problem in this patch, but as you said this
should be tested.
Currently due to Covid-19 I'm not able to access the HW and I cannot
validate this suggestion.
Hi Dragan,
Thanks for the review, and for *wanting* to do the testing, even though you
can't right now. :)
thanks,
--
John Hubbard
NVIDIA
drivers/misc/xilinx_sdfec.c | 30 +++++++++++++++++-------------
1 file changed, 17 insertions(+), 13 deletions(-)
base-commit: 9cb1fd0efd195590b828b9b865421ad345a4a145
--
2.26.2
