From: Borislav Petkov <[email protected]> Instruction opcode bytes spelled using the gas directive .byte should carry a comment above them stating which binutils version has added support for the instruction mnemonic so that they can be replaced with the mnemonic when that binutils version is equal or less than the minimum-supported version by the kernel.
Add a check for that. Requested-by: Peter Zijlstra <[email protected]> Signed-off-by: Borislav Petkov <[email protected]> Signed-off-by: Joe Perches <[email protected]> --- v4: trivial neatening of $Hex_byte and adding a mechanism to only emit the message once per patched file (Joe) scripts/checkpatch.pl | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index fab38b493cef..7568f583701c 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -414,6 +414,7 @@ our $Lval = qr{$Ident(?:$Member)*}; our $Int_type = qr{(?i)llu|ull|ll|lu|ul|l|u}; our $Binary = qr{(?i)0b[01]+$Int_type?}; our $Hex = qr{(?i)0x[0-9a-f]+$Int_type?}; +our $Hex_byte = qr{(?i)0x[0-9a-f]{1,2}\b}; our $Int = qr{[0-9]+$Int_type?}; our $Octal = qr{0[0-7]+$Int_type?}; our $String = qr{"[X\t]*"}; @@ -2408,6 +2409,7 @@ sub process { my $comment_edge = 0; my $first_line = 0; my $p1_prefix = ''; + my $warned_binutils = 0; my $prev_values = 'E'; @@ -2589,6 +2591,7 @@ sub process { $realfile =~ s@^([^/]*)/@@ if (!$file); $in_commit_log = 0; $found_file = 1; + $warned_binutils = 0; } elsif ($line =~ /^\+\+\+\s+(\S+)/) { $realfile = $1; $realfile =~ s@^([^/]*)/@@ if (!$file); @@ -2606,6 +2609,7 @@ sub process { "do not modify files in include/asm, change architecture specific files in include/asm-<architecture>\n" . "$here$rawline\n"); } $found_file = 1; + $warned_binutils = 0; } #make up the handle for any error we report on this line @@ -6954,6 +6958,20 @@ sub process { WARN("DUPLICATED_SYSCTL_CONST", "duplicated sysctl range checking value '$1', consider using the shared one in include/linux/sysctl.h\n" . $herecurr); } + +# document which binutils version supports the actual insn mnemonic so that the naked opcode bytes can be replaced. +# x86-only. Upper limit is rather arbitrary (max insn length on x86) but imposed so as to avoid perl aborts. + if (!$warned_binutils && + $realfile =~ m@^arch/x86/@ && + $rawline =~ /\s*\.byte\s+$Hex_byte(?:\s*,\s*$Hex_byte){0,14}/) { + + my $comment = ctx_locate_comment($file ? 0 : $first_line, $linenr); + if ($comment !~ /binutils (?:version )*[0-9.]+/ms) { + WARN("MISSING_BINUTILS_VERSION", + "Please consider documenting which binutils version supports these .byte-spelled insn opcodes by adding \"binutils version <num>\" in a comment above them\n" . $herecurr); + $warned_binutils = 1; + } + } } # If we have no input at all, then there is nothing to report on
