On Thu, Mar 5, 2026 at 3:14 PM Christoph Hellwig <[email protected]> wrote: > On Wed, Mar 04, 2026 at 08:04:09PM +0100, Andreas Gruenbacher wrote: > > Instead of setting bio->bi_status to BLK_STS_IOERR and calling > > bio_endio(bio), use the shorthand bio_io_error(bio). > > I'm a little torn how good these helpers actually are, as > hard coding one specific type of error seems to create weird > code and lead to bugs like the xfs one you fixed yesterday. > > Maybe we just need a bio_endio_status() that allows passing the > status?
I'm not particularly attached to bio_io_error(bio); it's been around forever but it can be confusing. Any thoughts on replacing it with a new bio_endio_status(bio, BLK_STS_IOERR) helper instead of keeping two mechanisms for doing the same thing? > Also you really need to send one patch per subsystem. I'm really trying to avoid that for simple, obviously correct, mechanical changes that can be recreated from scratch any time. Thanks, Andreas
