On 4/28/26 10:14, Bjorn Helgaas wrote:
On Mon, Apr 27, 2026 at 07:22:12PM -0700, Mukesh R wrote:
On 4/27/26 09:31, Bjorn Helgaas wrote:
On Tue, Apr 21, 2026 at 07:32:34PM -0700, Mukesh R wrote:
Main change here is to rename hv_compose_msi_msg to
hv_vmbus_compose_msi_msg as we introduce hv_compose_msi_msg in upcoming
patches that builds MSI messages for both VMBus and non-VMBus cases. VMBus
is not used on baremetal root partition for example. While at it, replace
spaces with tabs and fix some formatting involving excessive line wraps.
Would be better to do the whitespace changes in their own patch,
although several of them should just be dropped (see below).
- * facilities. For instance, the configuration space of a function exposed
+ * facilities. For instance, the configuration space of a function exposed
Oops, this hunk made it worse. Definitely don't want a tab there.
- * The vector we select here is a dummy value. The correct
+ * The vector we select here is a dummy value. The correct
Another tab that should be a space. Actually, you should just drop
this hunk; the rest of the comment has two spaces after periods, so
this should too.
well, most of our files does global replace 8 spaces with tabs, so
everywhere comments are well indented. Since, checkpatch doesn't complain
about tabs on comment lines, may I assue it is not a strict requirement
and more a nit or personal preference?
I guess I didn't make it clear. I'm not complaining about leading
tabs; I'm pointing out that the comments should not have embedded tabs
in the middle between a period and the first word of the next
sentence.
Oh, my bad, sorry, i didnt' realize that. Thank you, will def get rid
of them (most likely resulted from: vim %retab! command).
Thanks,
-Mukesh
Here's what it looks like with "git show | cat -T":
- * facilities. For instance, the configuration space of a function exposed
+ * facilities.^IFor instance, the configuration space of a function exposed
^^
-^I^I * The vector we select here is a dummy value. The correct
+^I^I * The vector we select here is a dummy value.^IThe correct
^^
-^I^I * freed while we dereference the ring buffer pointer. Test
+^I^I * freed while we dereference the ring buffer pointer.^ITest
^^
-^I * to be overlapped by those children. Set the flag on this claim
+^I * to be overlapped by those children.^ISet the flag on this claim
^^
None of these hunks should be here. Maybe some automation gone wrong?
In any case, every hunk of a patch that does "rename
hv_compose_msi_msg to hv_vmbus_compose_msi_msg" should contain those
names. Any whitespace changes should be in their own patch so they
don't make it hard to review the rename.
