On Mon, 29 Jun 2026 17:49:06 +0200, Andy Shevchenko <[email protected]> said: > On Mon, Jun 29, 2026 at 12:52:08PM +0200, Bartosz Golaszewski wrote: >> Add a kunit test suite for fw_devlink support for software nodes. >> >> Most cases call add_links() directly and inspect the resulting fwnode >> supplier/consumer lists: a single reference, multiple references, a >> reference to an unregistered node, a "remote-endpoint" reference and a >> reference array. The last case is end-to-end - it registers real consumer >> and supplier platform devices together with their drivers, adds the >> consumer first and checks that fw_devlink defers its probe until the >> supplier has been bound. > > ... > >> --- >> drivers/base/test/Kconfig | 5 + >> drivers/base/test/Makefile | 3 + >> drivers/base/test/swnode-devlink-test.c | 336 >> ++++++++++++++++++++++++++++++++ > > + MAINTAINERS. > > ... > > >> +/* A single reference creates exactly one supplier link, on both list ends. >> */ >> +static void swnode_devlink_test_single_ref(struct kunit *test) >> +{ >> + static const struct software_node supp_swnode = { >> + .name = "swnode-devlink-test-supplier" > > Keep trailing comma. > >> + }; > >> + > > Redundant blank line. >
I actually leave a blank line between static, const and regular local variable blocks for readability. Bart
