On Mon, 6 Jul 2026 22:05:43 +0200, Andy Shevchenko <[email protected]> said: > On Mon, Jul 06, 2026 at 07:42:36AM -0400, Bartosz Golaszewski wrote: >> On Mon, 29 Jun 2026 17:49:06 +0200, Andy Shevchenko >> <[email protected]> said: >> > On Mon, Jun 29, 2026 at 12:52:08PM +0200, Bartosz Golaszewski wrote: > > ... > >> >> + static const struct software_node supp_swnode = { >> >> + .name = "swnode-devlink-test-supplier" >> > >> > Keep trailing comma. >> > >> >> + }; >> > >> >> + >> > >> > Redundant blank line. >> > >> >> I actually leave a blank line between static, const and regular local >> variable >> blocks for readability. > > As far as I know this is against the style. >
I don't think the docs mention this particular situation - correct me if I'm wrong. Since I wrote it, I'll likely maintain this file and my personal preference is to keep the newlines. I hope it's fine. Bart
