On Mon, Jul 27, 2026 at 05:58:47PM -0700, Borislav Petkov wrote:
> On Mon, Jul 27, 2026 at 05:18:02PM -0400, Atharva Tiwari wrote:
> > Add a flag to detect Apple T2 chips on Intel Macs.
> > Cache the result to avoid repeated checks. That will
> > be used in upcoming patches.

Why don't you use match_string()?

...

> >  bool x86_apple_machine;
> >  EXPORT_SYMBOL(x86_apple_machine);
> >  
> > +bool has_apple_t2_chip;
> > +EXPORT_SYMBOL(has_apple_t2_chip);
> 
> I'm guessing this is parrotting the non-GPL export of x86_apple_machine from
> 
>   630b3aff8a51 ("treewide: Consolidate Apple DMI checks")
> 
> Lemme add those folks and ask why aren't those exports GPL only?

I don't remember the details, but brief grepping shows no impediments (from my
p.o.v.) to make them GPL. Maybe Lukas knows more?

-- 
With Best Regards,
Andy Shevchenko



Reply via email to