> > On Tue, 18 Aug 2026 09:20:05 -0700 Jakub Kicinski wrote: > > On Thu, 13 Aug 2026 10:42:33 -0700 Long Li wrote: > > > } > > > > > > +static struct gdma_queue *mana_gd_get_cq(struct gdma_context *gc, > > > +u32 cq_id); static void mana_gd_put_cq(struct gdma_queue *cq); > > > > Forward declarations are considered a bad smell in the kernel. > > Please add these functions here, I don't see a reason for this they > > are purely calling kernel APIs. > > > > > static void mana_gd_process_eqe(struct gdma_queue *eq) > > Well, prolly not gonna have time to review the rest this week due to the > merge window, so pls TAL at the AI review as well before you respin: > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fnetdev > - > ai.bots.linux.dev%2Fsashiko%2F%23%2Fpatchset%2F20260813174243.304434 > 8-2- > longli%40microsoft.com&data=05%7C02%7Clongli%40microsoft.com%7Cbf02 > ba497de64cc264b108defd44b162%7C72f988bf86f141af91ab2d7cd011db47%7 > C1%7C0%7C639226668643687247%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0 > eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCI > sIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=JYiJcy2lD1rOwRKuxfrm3zm8JR2n > rwDggk0GC%2FgH8eE%3D&reserved=0
Will do, thank you. Long
