On Tue, 18 Aug 2026 09:20:05 -0700 Jakub Kicinski wrote: > On Thu, 13 Aug 2026 10:42:33 -0700 Long Li wrote: > > } > > > > +static struct gdma_queue *mana_gd_get_cq(struct gdma_context *gc, u32 > > cq_id); > > +static void mana_gd_put_cq(struct gdma_queue *cq); > > Forward declarations are considered a bad smell in the kernel. > Please add these functions here, I don't see a reason for this > they are purely calling kernel APIs. > > > static void mana_gd_process_eqe(struct gdma_queue *eq)
Well, prolly not gonna have time to review the rest this week due to the merge window, so pls TAL at the AI review as well before you respin: https://netdev-ai.bots.linux.dev/sashiko/#/patchset/[email protected]
