* Paolo Ciarrocchi <[EMAIL PROTECTED]> wrote:
> > /*
> > - * Set up an actual MCR
> > + * Set up an actual MCR
> > */
>
> This was not highlighted by checkpatch.pl, right? The same applies for
> a few other "fix" you did on some comments.
correct - it's not fixes, just bringing it in line with the common
comment style we use. The file was using lots of inconsistent comment
styles.
> [...]
> > {
> > - u32 mem = ramtop();
> > u32 root = power2(mem);
> > + u32 mem = ramtop();
>
> Can you please explain the rationale behind this change?
it's a bug :) It got pointed out by Joe Perches and i fixed it. (the
size check would have caught it too)
> > - E2MMX = 1<<19,
> > - EAMD3D = 1<<20,
> > - };
>
> I see why you did the cleanup but I think even this part was not
> catched by checkpatch.pl
yes, as i said:
> > Some of them are real CodingStyle problems, some of them are just
> > arbitrary taste details.
checkpatch.pl is a helper tool which highlights some of the clear
problem - but when we clean up files we try to make it appear consistent
in all its details. My patch was a demonstration of what else can be
fixed in a file until it's really clean looking in its entirety.
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
