On Tue, 2012-09-18 at 12:09 +0530, viresh kumar wrote: [snip]
> > +#define dma_raw_readl(addr, name) \ > > + readl((addr) + offsetof(struct dw_dma_regs, name)) > > + > > +#define dma_raw_writel(addr, name, val) \ > > + writel((val), (addr) + offsetof(struct dw_dma_regs, name)) > > + > > But why don't you use earlier defined readl/writel macros: > dma_readl and dma_writel? If you look at further patches, namely 3rd, the access to the register is needed before we allocate memory for the dw_dma structure. -- Andy Shevchenko <[email protected]> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
