On Tue, Sep 18, 2012 at 12:25 PM, Andy Shevchenko <[email protected]> wrote: >> > +#define dma_raw_readl(addr, name) \ >> > + readl((addr) + offsetof(struct dw_dma_regs, name)) >> > + >> > +#define dma_raw_writel(addr, name, val) \ >> > + writel((val), (addr) + offsetof(struct dw_dma_regs, name)) >> > + >> >> But why don't you use earlier defined readl/writel macros: >> dma_readl and dma_writel?
> If you look at further patches, namely 3rd, the access to the register > is needed before we allocate memory for the dw_dma structure. Ok. If i am not wrong, such calls are only required once for below line: dw_params = dma_raw_readl(regs, DW_PARAMS dma_raw_writel() is not used and shouldn't be required in future too. So remove it. dma_raw_readl() is required but the name is a bit confusing... this raw type is different from raw_readl... Can we name it dma_read_byaddr()? to make it more explicit. viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
