Namjae Jeon <[email protected]> writes: > In calling of __fat_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL), > expression "wbc->sync_mode == WB_SYNC_ALL" will always be equivalent to value > of wbc->sync_mode. So, remove this additional compare condition from function > arguments.
Current style is better. I.e. easy to add new sync mode. > Signed-off-by: Namjae Jeon <[email protected]> > Signed-off-by: Amit Sahrawat <[email protected]> > --- > fs/fat/inode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/fat/inode.c b/fs/fat/inode.c > index 7b186a5..aa0138b 100644 > --- a/fs/fat/inode.c > +++ b/fs/fat/inode.c > @@ -678,7 +678,7 @@ static int fat_write_inode(struct inode *inode, struct > writeback_control *wbc) > err = fat_clusters_flush(sb); > mutex_unlock(&MSDOS_SB(sb)->s_lock); > } else > - err = __fat_write_inode(inode, wbc->sync_mode == WB_SYNC_ALL); > + err = __fat_write_inode(inode, wbc->sync_mode); > > return err; > } -- OGAWA Hirofumi <[email protected]> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
