* Peter Zijlstra <[email protected]> wrote: > On Thu, May 08, 2014 at 04:59:53PM +0900, Namhyung Kim wrote: > > Currently perf record doesn't propagate the exit status of a workload > > given by the command line. But sometimes it'd useful if it's > > propagated so that a monitoring script can handle errors > > appropriately. > > > > To do that, it got rid of exit handlers and run/call them directly in > > the __cmd_record(). I don't see any reason why those are in a form of > > exit handlers in the first place. Also it cleaned up the resource > > management code in record__exit(). > > > > With this change, perf record returns the child exit status in case of > > normal termination and send signal to itself when terminated by signal. > > > > Example run of Stephane's case: > > > > $ perf record true && echo yes || echo no > > [ perf record: Woken up 1 times to write data ] > > [ perf record: Captured and wrote 0.013 MB perf.data (~589 samples) ] > > yes > > > > $ perf record false && echo yes || echo no > > [ perf record: Woken up 1 times to write data ] > > [ perf record: Captured and wrote 0.013 MB perf.data (~589 samples) ] > > no > > > > Jiri's case (error in parent): > > > > $ perf record -m 10G true && echo yes || echo no > > rounding mmap pages size to 17179869184 bytes (4194304 pages) > > failed to mmap with 12 (Cannot allocate memory) > > no > > > > And Peter's case (interrupted by signal): > > > > $ while :; do perf record sleep 1; done > > ^C[ perf record: Woken up 1 times to write data ] > > [ perf record: Captured and wrote 0.014 MB perf.data (~593 samples) ] > > Thanks! > > Acked-by: Peter Zijlstra <[email protected]>
Very nice! Acked-by: Ingo Molnar <[email protected]> Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
