On Mon, Jun 16, 2014 at 09:17:14AM -0400, Peter Hurley wrote: > Since at least before 2.6.30, tty drivers that do not drop the tty lock > while closing cannot observe ASYNC_CLOSING set while holding the > tty lock; this includes the tty driver's open() and hangup() methods, > since the tty core calls these methods holding the tty lock. > > For these drivers, waiting for ASYNC_CLOSING to clear while opening > is not required, since this condition cannot occur. Similarly, even > when the open() method drops and reacquires the tty lock after > blocking, ASYNC_CLOSING cannot be set (again, for drivers that > do not drop the tty lock while closing). > > Now that tty port drivers no longer drop the tty lock while closing > (since 'tty: Remove tty_wait_until_sent_from_close()'), the same > conditions apply: waiting for ASYNC_CLOSING to clear while opening > is not required, nor is re-checking ASYNC_CLOSING after dropping and > reacquiring the tty lock while blocking (eg., in *_block_til_ready()). > > Since ASYNC_CLOSING is not tested elsewhere, it is safe to remove > the flag. > > CC: Martin Schwidefsky <[email protected]> > CC: Heiko Carstens <[email protected]> > CC: [email protected] > CC: Mikael Starvik <[email protected]>
For the CRIS part: Acked-by: Jesper Nilsson <[email protected]> > CC: [email protected] > CC: Samuel Ortiz <[email protected]> > CC: "David S. Miller" <[email protected]> > Signed-off-by: Peter Hurley <[email protected]> /^JN - Jesper Nilsson -- Jesper Nilsson -- [email protected] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
