Hi David,
On 06/16/2014 11:37 AM, David Laight wrote:
From: Of Peter Hurley
ASYNC_CLOSING is no longer used in the tty core; use private flag
info->closing as substitute.
...
@@ -311,6 +311,7 @@ typedef struct atemu {
typedef struct modem_info {
int magic;
struct tty_port port;
+ int closing:1; /* port count has dropped to 0 */
int x_char; /* xon/xoff character */
int mcr; /* Modem control register */
int msr; /* Modem status register */
That should probably be a bool and set to true/false.
You are probably adding a load of padding.
struct modem_info is over 1K, with several existing int-as-bool fields.
An array of 64 struct modem_info are statically allocated with every isdn
device.
It doesn't look like memory consumption has been a consideration with the isdn
driver.
Regards,
Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
