On Mon, Jun 29, 2015 at 02:17:18PM +0300, Adrian Hunter wrote: > On 29/06/15 14:12, Jiri Olsa wrote: > > Missing switch break since introduction of new event: > > c4937a91ea56 perf tools: handle PERF_RECORD_LOST_SAMPLES > > > > Cc: Kan Liang <[email protected]> > > Cc: Adrian Hunter <[email protected]> > > Link: http://lkml.kernel.org/n/[email protected] > > Signed-off-by: Jiri Olsa <[email protected]> > > --- > > tools/perf/util/machine.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > > index 4744673aff1b..a08e38339cac 100644 > > --- a/tools/perf/util/machine.c > > +++ b/tools/perf/util/machine.c > > @@ -1448,7 +1448,7 @@ int machine__process_event(struct machine *machine, > > union perf_event *event, > > case PERF_RECORD_AUX: > > ret = machine__process_aux_event(machine, event); break; > > case PERF_RECORD_ITRACE_START: > > - ret = machine__process_itrace_start_event(machine, event); > > + ret = machine__process_itrace_start_event(machine, event); > > break; > > case PERF_RECORD_LOST_SAMPLES: > > ret = machine__process_lost_samples_event(machine, event, > > sample); break; > > break; > > But now you have break; break;
hum, I did not see the PERF_RECORD_LOST_SAMPLES has 2 breaks already, anyway the one for PERF_RECORD_ITRACE_START is missing > Isn't putting 'break' on the end of the line making things harder to read? I guess, but looks like we dont have firm style in this.. attaching v2 with the extra break removal thanks, jirka --- Missing switch break since introduction of new event: c4937a91ea56 perf tools: handle PERF_RECORD_LOST_SAMPLES Also removing unneeded break for PERF_RECORD_LOST_SAMPLES. Cc: Kan Liang <[email protected]> Cc: Adrian Hunter <[email protected]> Link: http://lkml.kernel.org/n/[email protected] Signed-off-by: Jiri Olsa <[email protected]> --- tools/perf/util/machine.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c index 4744673aff1b..7ff682770fdb 100644 --- a/tools/perf/util/machine.c +++ b/tools/perf/util/machine.c @@ -1448,10 +1448,9 @@ int machine__process_event(struct machine *machine, union perf_event *event, case PERF_RECORD_AUX: ret = machine__process_aux_event(machine, event); break; case PERF_RECORD_ITRACE_START: - ret = machine__process_itrace_start_event(machine, event); + ret = machine__process_itrace_start_event(machine, event); break; case PERF_RECORD_LOST_SAMPLES: ret = machine__process_lost_samples_event(machine, event, sample); break; - break; default: ret = -1; break; -- 1.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
