On Tue, 10 Mar 2009 12:09:48 +0200 Antti Palosaari <cr...@iki.fi> wrote:
> Mauro, > Could you remove this bad patch patch soon? It must not go to the final > 2.6.29 as it breaks so many old devices. One of those is MSI Megasky 580 > which is rather popular. > > regards > Antti > > Antti Palosaari wrote: > > Hello, > > This patch breaks devices using tuner behind zl10353 i2c-gate. > > au6610: > > Sigmatek DVB-110 DVB-T USB2.0 > > > > gl861: > > MSI Mega Sky 55801 DVB-T USB2.0 > > A-LINK DTU DVB-T USB2.0 > > > > Probably some other too. > > > > I think it is better to disable i2c-gate setting callback to NULL after > > demod attach like dtv5100 does this. > > > > Also .no_tuner is bad name what it does currently. My opinion is that > > current .no_tuner = 1 should be set as default, because most > > configuration does not this kind of slave tuner setup where tuner is > > programmed by demod. > > Change no_tuner to slave_tuner and set slave_tuner = 1 only when needed > > (not many drivers using that). Hi Antti/Dmitri, I agree that no_tuner is a bad name. The best is to rename it to something like "tuner_is_behind_bridge". If equal to 1, then it will use the new behaviour, otherwise the old one, and fix the boards where this trouble were found. Could one of you please do such patchset? Thanks, Mauro. -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
