One more thing I noticed while looking at your patch 3/4:
> +static int pcm990_camera_set_bus_param(struct device *dev,
> + unsigned long flags)
> +{
> + if (gpio_bus_switch <= 0)
> + return 0;
> +
> + if (flags & SOCAM_DATAWIDTH_8)
> + gpio_set_value(NR_BUILTIN_GPIO + 1, 1);
> + else
> + gpio_set_value(NR_BUILTIN_GPIO + 1, 0);
Originally the logic here was "only if flags == SOCAM_DATAWIDTH_8, switch
to 8 bits, otherwise do 10 bits. I.e., if flags == SOCAM_DATAWIDTH_8 |
SOCAM_DATAWIDTH_10, it would still do the default (and wider) 10 bits. Do
you have any reason to change that logic?
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
