Jon,
     if you agree to change it in another patch, and now just to keep
it with the driver that works for years.
     that is OK. thanks.
     I am looking forward your patch based on VB2, because based on
current cafe_ccic.c, it is hard to share with my driver.

2011/6/14 Jonathan Corbet <cor...@lwn.net>:
> On Tue, 14 Jun 2011 10:23:58 +0800
> Kassey Lee <kassey1...@gmail.com> wrote:
>
>> Jon, Here is my comments.
>
> Thanks for having a look.
>
>> > +config VIDEO_CAFE_CCIC
>> > +       tristate "Marvell 88ALP01 (Cafe) CMOS Camera Controller support"
>> > +       depends on PCI && I2C && VIDEO_V4L2
>> > +       select VIDEO_OV7670
>> >
>>  why need binds with sensor ? suppose CCIC driver and sensor driver are
>> independent, even if your hardware only support OV7670
>
> We all agree that needs to change.  This particular patch, though, is
> concerned with moving a working driver into a new directory; making that
> sort of functional change would not be appropriate here.
>
>> > +#include <media/ov7670.h>
>> >
>>      ccic would not be aware of the sensor name.
>
> Ditto.
>
> Thanks,
>
> jon
>



-- 
Best regards
Kassey
Application Processor Systems Engineering, Marvell Technology Group Ltd.
Shanghai, China.
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to