On Fri, Sep 11, 2015 at 5:55 PM, Laura Abbott <[email protected]> wrote:
>
> Until log_setup_kmod_log is called, the only messages that
> can be printed are the default level. Bump a few deprecated
> messages to ERR to ensure they get printed and drop some DBG
> prints that will never occur unless the compiled default is DBG.
> ---
> tools/depmod.c | 10 ++++------
> 1 file changed, 4 insertions(+), 6 deletions(-)
>
> diff --git a/tools/depmod.c b/tools/depmod.c
> index 2a08b6e..30f6191 100644
> --- a/tools/depmod.c
> +++ b/tools/depmod.c
> @@ -2455,10 +2455,10 @@ static int do_depmod(int argc, char *argv[])
> case 'r':
> case 'm':
> if (idx > 0)
> - WRN("Ignored deprecated option --%s\n",
> + ERR("Ignored deprecated option --%s\n",
> cmdopts[idx].name);
> else
> - WRN("Ignored deprecated option -%c\n", c);
> + ERR("Ignored deprecated option -%c\n", c);
/me confused. The default priority for depmod is LOG_WARNING
> break;
> case 'h':
> @@ -2498,11 +2498,9 @@ static int do_depmod(int argc, char *argv[])
> if (out == stdout)
> goto done;
> /* ignore up-to-date errors (< 0) */
> - if (depfile_up_to_date(cfg.dirname) == 1) {
> - DBG("%s/modules.dep is up to date!\n", cfg.dirname);
> + if (depfile_up_to_date(cfg.dirname) == 1)
> goto done;
> - }
> - DBG("%s/modules.dep is outdated, do -a\n", cfg.dirname);
> +
I don't mind losing these log messages. I guess they were useful in
the beginning but they aren't anymore.
Lucas De Marchi
> all = 1;
> }
>
> --
> 2.4.3
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-modules" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Lucas De Marchi
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
