On 09/12/2015 12:00 PM, Lucas De Marchi wrote:
On Fri, Sep 11, 2015 at 5:55 PM, Laura Abbott <[email protected]> wrote:

Currently, if a value that doesn't match a kernel version
("%u.%u") is passed in, depmod silently falls back to
using uname. Make it clear to the user that this is happening
by giving a message to the user.
---

Actually I think we should not fallback. If the user passed a wrong
number, fallbacking to the currently running kernel is plain wrong.
This was done mostly due to compatibility with module-init-tools but I
prefer breaking it rather than silently (or verbose as per your patch)
doing the wrong thing.


Sounds fine to me if you are okay with the breakage.

Thanks,
Laura
--
To unsubscribe from this list: send the line "unsubscribe linux-modules" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to