On Sat, Oct 07, 2017 at 08:14:42AM -0700, Dan Williams wrote:
[...]

> +rxe_cfg stop
> +rxe_cfg start
> +if ! rxe_cfg status | grep -n rxe0; then
> +     rxe_cfg add eth0
> +fi

Can we maybe skip the dependency on rxe_cfg? All that is needed is modprobe
and echo. Also hard coding eth0 might be problematic in this case. This works
on your test-setup but surely isn't portable.

Byte,
        Johannes

-- 
Johannes Thumshirn                                          Storage
[email protected]                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

Reply via email to